Skip to content

Conversation

@jysandy
Copy link
Member

@jysandy jysandy commented Jan 8, 2018

No description provided.


;; - So suppose we define...

(def habitable-planets [{:pname "Earth" :moons 1}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling them habitable-planets to begin with adds a lot of confusion at line 81, where you evaluate habitable-planets and it returns the planets unchanged, which just looks like all planets are habitable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

;; At each re-definition, `am-i-mutable` effectively "becomes"
;; the new _immutable_ value.
;;
;; "Immutable" value is actually an oxymoron. Recall, we said that
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Immutable" value is a tautology. "Mutable" value is an oxymoron. We can choose to use one or the other.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayyo! Yes, /s/Immutable/Mutable


;; We can also alias the whole hash-map:

(let [add-message (fn [{:keys [pname moons]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These function bodies are starting to get bigger, and putting them in let blocks makes them harder to visually parse.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, let's pull them out. I can do it... Should I?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you did it... I missed that. 💯

;; At each re-definition, `am-i-mutable` effectively "becomes"
;; the new _immutable_ value.
;;
;; "Immutable" value is actually an oxymoron. Recall, we said that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayyo! Yes, /s/Immutable/Mutable

@adityaathalye adityaathalye merged commit 15a32cb into master Jan 8, 2018
@adityaathalye adityaathalye deleted the ex-05-feedback branch January 19, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants